Skip to content

Fix recursion SVG loop rendering for _~_ diagrams #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix recursion SVG loop rendering for _~_ diagrams #1198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c8b110
Initial plan
Copilot Dec 30, 2025
4733650
fix: render recursion svg feedback loop
Copilot Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions compiler/draw/schema/recSchema.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ void recSchema::collectTraits(collector& c)

// draw the feedback connections to each fSchema2 input
for (unsigned int i = 0; i < fSchema2->inputs(); i++) {
collectFeedback(c, fSchema1->outputPoint(i), fSchema2->inputPoint(i), i * dWire,
double offset = (i + 1) * dWire;
collectFeedback(c, fSchema1->outputPoint(i), fSchema2->inputPoint(i), -offset,
outputPoint(i));
}

Expand All @@ -187,7 +188,8 @@ void recSchema::collectTraits(collector& c)

// draw the feedfront connections from each fSchema2 output
for (unsigned int i = 0; i < fSchema2->outputs(); i++) {
collectFeedfront(c, fSchema2->outputPoint(i), fSchema1->inputPoint(i), i * dWire);
double offset = (i + 1) * dWire;
collectFeedfront(c, fSchema2->outputPoint(i), fSchema1->inputPoint(i), offset);
}
}

Expand All @@ -204,6 +206,9 @@ void recSchema::collectFeedback(collector& c, const point& src, const point& dst
point up(ox, src.y - ct);
point br(ox + ct / 2.0, src.y);

c.addOutput(src);
c.addInput(dst);
c.addOutput(point(ox, dst.y));
c.addOutput(up);
c.addOutput(br);
c.addInput(br);
Expand All @@ -222,6 +227,10 @@ void recSchema::collectFeedfront(collector& c, const point& src, const point& ds
{
double ox = src.x + ((orientation() == kLeftRight) ? -dx : dx);

c.addOutput(src);
c.addInput(dst);
c.addOutput(point(ox, src.y));
c.addInput(point(ox, dst.y));
c.addTrait(trait(point(src.x, src.y), point(ox, src.y)));
c.addTrait(trait(point(ox, src.y), point(ox, dst.y)));
c.addTrait(trait(point(ox, dst.y), point(dst.x, dst.y)));
Expand Down