-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Composer::boundary()
#763
Open
KnorpelSenf
wants to merge
8
commits into
main
Choose a base branch
from
bot-surround
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+95
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose I want to write a tree surrounding plugin, with regular middleware plugins I would simply be able to write: type Options = { foo: string };
function myPlugin<C extends Context>(options?: Options): Middleware<C> {
return (ctx, next) => {
// ...
};
}
bot.use(myPlugin({ foo: "bar" })); It would be nice to be able to do something similar for a surrounding middleware: export type SurroundingMiddlewareFn<C extends Context = Context> = (
ctx: C,
tree: () => Promise<{ nextCalled: boolean }>,
next: NextFunction,
) => MaybePromise<unknown>;
function mySurroundingPlugin<C extends Context>(
options?: Options,
): SurroundingMiddlewareFn<C> {
return (ctx, tree, next) => {
// ...
};
}
const surrounded = bot.surround(mySurroundingPlugin({ foo: "baz" })); |
KnightNiwrem
approved these changes
Feb 23, 2025
rayz1065
approved these changes
Feb 23, 2025
rayz1065
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @rayz1065