Make gramps.plugins.db.dbapi.dbapi typed
#2017
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartfeenstra
force-pushed
the
typed-dbapi
branch
from
64f263b to
43cd450
Compare
bartfeenstra
force-pushed
the
typed-dbapi
branch
from
43cd450 to
884806b
Compare
|
oops, duplicate of #1919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of arguments and return values remain untyped, because I'm not familiar enough with this part of Gramps just yet.
Additionally, as a learning note: in the future we should move from typing on
dictandlisttoMapping,MutableMapping,Sequence, andMutableSequenceas they allow other, compatible types to be used. I did not do that now as all these methods are documented to use lists or dicts explicitly.