Skip to content

Conversation

@KOLANICH
Copy link

@KOLANICH KOLANICH commented Sep 13, 2021

Added pyproject.toml.
Replaced importing the version variable with reading it from the file using read_version.
If we drop python3 ./setup.py test, then setup.py can be removed completely since now (to build one should use python3 -m build -nwx).

Added `pyproject.toml`.
Replaced importing the version variable with reading it from the file using `read_version`.
If we drop `python3 ./setup.py test`, then `setup.py` can be removed completely since now (to build one should use `python3 -m build -nwx`).
@grantjenks
Copy link
Owner

Does the current setup.py cause you problems?

@KOLANICH
Copy link
Author

KOLANICH commented Sep 13, 2021

setup.py is a security issue. It is code execution at the time of building a wheel from source. Since tools in python ecosystem support the declarative config (setup.cfg is supported in setuptools since 2016, setuptools support projects without setup.py since 2019, pip supports projects without setup.py since my PR fixing that has landed 2021-03-04)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants