Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix camera intrinsics #568

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shewangmu
Copy link

Hello, I find that in some situations, the rendering result of GS is very blurry, especially around the edge. This behaves very differently from other cases.
Then I locate the problem with camera intrinsics. You didn't consider about the cx and cy.
After this bug fixing, the result improves a lot.
Additionally, just a reminder, I find the L2 loss behaves more stable than L1. L1 seems to cause more artifacts (in object rendering).

@grgkopanas
Copy link
Collaborator

Indeed that is true, but we cannot accept this pull request. To be complete you need to make sure that you consider the cx and cy when computing the forward and backward pass in cuda when we compute the 2D covariance matrix of the Gaussians based on the jacobian of the transformation.

@shewangmu
Copy link
Author

Indeed that is true, but we cannot accept this pull request. To be complete you need to make sure that you consider the cx and cy when computing the forward and backward pass in cuda when we compute the 2D covariance matrix of the Gaussians based on the jacobian of the transformation.

Thank you for your suggestion, I will check it on Monday. However, I test this change under several situations and it works right. I am not sure whether it’s necessary or not.

@kwea123
Copy link

kwea123 commented Dec 22, 2023

just change the projection matrix to this #399 and it works with the current cuda implementation.

@shewangmu
Copy link
Author

just change the projection matrix to this #399 and it works with the current cuda implementation.

Yes, the projection matrix in the issue you mentioned is just the same with this commit. And I have checked the result under many cases.

Copy link

@kwea123 kwea123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants