Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handling more explicit, and warn user if they haven't #510

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Nov 15, 2024

Description

If you pass a pool to Graphile Worker, that pool ought to have error handlers. We've done this for you in the past, but that can result in adding lots of error handlers to the pool. Now we only add the error handlers if there aren't already any, plus we tell you that you should be doing it yourself.

Performance impact

Negligible startup cost.

Security impact

Improvement: encouraging users to handle their own errors.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

@benjie benjie merged commit 4d71970 into main Nov 15, 2024
14 checks passed
@benjie benjie deleted the pool-error-handling branch November 15, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant