chore: use an existing function to calculate diff or zero if underflow

graphprotocol · Aug 2, 2022 · 0ec8778 · 0ec8778
1 parent 9ac3b07
commit 0ec8778
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/contracts/rewards/RewardsManager.sol b/contracts/rewards/RewardsManager.sol
@@ -6,6 +6,7 @@ pragma abicoder v2;
 import "@openzeppelin/contracts/math/SafeMath.sol";
 
 import "../upgrades/GraphUpgradeable.sol";
+import "../staking/libs/MathUtils.sol";
 
 import "./RewardsManagerStorage.sol";
 import "./IRewardsManager.sol";
@@ -281,12 +282,10 @@ contract RewardsManager is RewardsManagerV3Storage, GraphUpgradeable, IRewardsMa
         Subgraph storage subgraph = subgraphs[_subgraphDeploymentID];
 
         uint256 accRewardsForSubgraph = getAccRewardsForSubgraph(_subgraphDeploymentID);
-        uint256 newRewardsForSubgraph;
-        if (accRewardsForSubgraph > subgraph.accRewardsForSubgraphSnapshot) {
-            newRewardsForSubgraph = accRewardsForSubgraph.sub(
-                subgraph.accRewardsForSubgraphSnapshot
-            );
-        }
+        uint256 newRewardsForSubgraph = MathUtils.diffOrZero(
+            accRewardsForSubgraph,
+            subgraph.accRewardsForSubgraphSnapshot
+        );
 
         uint256 subgraphAllocatedTokens = staking().getSubgraphAllocatedTokens(
             _subgraphDeploymentID