fix: Use LegacyAllocationAlreadyMigrated. (OZ N-02)

graphprotocol · Sep 17, 2024 · f44e046 · f44e046
1 parent 9848954
commit f44e046
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/packages/subgraph-service/contracts/utilities/AllocationManager.sol b/packages/subgraph-service/contracts/utilities/AllocationManager.sol
@@ -169,19 +169,14 @@ abstract contract AllocationManager is EIP712Upgradeable, GraphDirectory, Alloca
     /**
      * @notice Imports a legacy allocation id into the subgraph service
      * This is a governor only action that is required to prevent indexers from re-using allocation ids from the
-     * legacy staking contract. It will revert if the allocation has already been migrated.
+     * legacy staking contract. It will revert with LegacyAllocationAlreadyMigrated if the allocation has already been migrated.
      * @param _indexer The address of the indexer
      * @param _allocationId The id of the allocation
      * @param _subgraphDeploymentId The id of the subgraph deployment
-     * @custom:error LegacyAllocationMigrated if the allocation has already been migrated
      */
     function _migrateLegacyAllocation(address _indexer, address _allocationId, bytes32 _subgraphDeploymentId) internal {
-        try legacyAllocations.migrate(_indexer, _allocationId, _subgraphDeploymentId) {
-            emit LegacyAllocationMigrated(_indexer, _allocationId, _subgraphDeploymentId);
-        } catch Error(string memory reason) {
-            revert(reason);
-        }
-    }
+        legacyAllocations.migrate(_indexer, _allocationId, _subgraphDeploymentId);
+        emit LegacyAllocationMigrated(_indexer, _allocationId, _subgraphDeploymentId);
 
     /**
      * @notice Create an allocation