Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRST audit fixes for Subgraph Service contracts #1074

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Nov 28, 2024

This PR addresses the following audit findings:

  • TRST-H-5 Allocations can be closed and historic rewards lost due to allocation power structure
  • TRST-M-6 Allocations could be created in both legacy and Horizon Staking, breaking assumptions
  • TRST-R-9 Documentation errors

@tmigone tmigone changed the title fix: overallocated condition no longer allows force closing (TRST-H05) TRST audit fixes for Subgraph Service contracts Nov 28, 2024
Copy link

openzeppelin-code bot commented Nov 28, 2024

TRST audit fixes for Subgraph Service contracts

Generated at commit: ac8a0711bd4e560e0ebd49f2a745b7d522e92ca9

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
39
60
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone tmigone force-pushed the tmigone/trust-fixes-subgraph-service branch from a49f0cd to 7efedcc Compare November 29, 2024 13:11
@tmigone tmigone merged commit 2fbe0e1 into horizon Dec 17, 2024
3 of 4 checks passed
@tmigone tmigone deleted the tmigone/trust-fixes-subgraph-service branch December 17, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants