Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove asset holder allowlist (with latest main) #855

Closed
wants to merge 13 commits into from

test: fix a case where it still expected an event

abe55a1
Select commit
Loading
Failed to load commit list.
Closed

feat: remove asset holder allowlist (with latest main) #855

test: fix a case where it still expected an event
abe55a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 24, 2023 in 0s

92.59% (+1.01%) compared to 765d43f

View this Pull Request on Codecov

92.59% (+1.01%) compared to 765d43f

Details

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (765d43f) 91.57% compared to head (abe55a1) 92.59%.

Files Patch % Lines
contracts/discovery/GNS.sol 97.40% 2 Missing ⚠️
contracts/staking/StakingExtension.sol 98.69% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           pcv/remove-asset-holder-check     #854      +/-   ##
=================================================================
+ Coverage                          91.57%   92.59%   +1.01%     
=================================================================
  Files                                 42       47       +5     
  Lines                               1995     2362     +367     
  Branches                             359      430      +71     
=================================================================
+ Hits                                1827     2187     +360     
- Misses                               168      175       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.