Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GNS): use the correct token amount when curation or owner tax are zero #873

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

pcarranzav
Copy link
Member

Before this fix, if curation or owner tax were zero, GNS would try to mint signal for the new version with zero tokens, which would revert.

@pcarranzav pcarranzav requested review from tmigone and Maikol October 31, 2023 21:26
Copy link

openzeppelin-code bot commented Oct 31, 2023

fix(GNS): use the correct token amount when curation or owner tax are zero

Generated at commit: 322658ed487c41db3a8dd33370c8392998b0671b

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
high
Total
32
18
1
1
52
Dependency Checker low
note
Total
1
23
24

For more details view the full report in OpenZeppelin Code

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfff549) 92.60% compared to head (322658e) 92.65%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   92.60%   92.65%   +0.04%     
==========================================
  Files          47       47              
  Lines        2368     2368              
  Branches      432      432              
==========================================
+ Hits         2193     2194       +1     
+ Misses        175      174       -1     
Flag Coverage Δ
unittests 92.65% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcarranzav pcarranzav self-assigned this Nov 7, 2023
Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also test it doesn't revert with _curationTaxPercentage = 0?

@pcarranzav
Copy link
Member Author

Should we also test it doesn't revert with _curationTaxPercentage = 0?

Good point, created #891 to address in a separate PR

@pcarranzav pcarranzav merged commit a667f7a into main Dec 7, 2023
8 checks passed
@pcarranzav pcarranzav deleted the pcv/fix-zero-owner-tax branch December 7, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants