Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add _curationTaxPercentage 0 case #931

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

fabian416
Copy link

This Pull Request adds a test case to ensure that the subgraph upgrade does not revert when _curationTaxPercentage is set to 0.

Resolves #891

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb4a03e) 92.69% compared to head (f71110d) 92.69%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          46       46           
  Lines        2369     2369           
  Branches      426      426           
=======================================
  Hits         2196     2196           
  Misses        173      173           
Flag Coverage Δ
unittests 92.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@pcarranzav pcarranzav merged commit 7b9766d into graphprotocol:main Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test subgraph upgrade doesn't revert with _curationTaxPercentage = 0
2 participants