Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphman: disable load management when using graphman #5875

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

incrypto32
Copy link
Member

Closes #5850

@incrypto32 incrypto32 self-assigned this Mar 6, 2025
@@ -1030,6 +1031,9 @@ impl Context {

#[tokio::main]
async fn main() -> anyhow::Result<()> {
// Disable load management for graphman commands
env::set_var("GRAPH_LOAD_THRESHOLD", "0");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't want to add a boolean flag in LoadManager::new just for this, so just hardset the env var here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that's fine for this.

@incrypto32 incrypto32 force-pushed the krishna/fix-graphman-query branch from 2e4ef20 to 7f1ed00 Compare March 6, 2025 13:34
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, how was the load manager interfering with graphman query?

@@ -1030,6 +1031,9 @@ impl Context {

#[tokio::main]
async fn main() -> anyhow::Result<()> {
// Disable load management for graphman commands
env::set_var("GRAPH_LOAD_THRESHOLD", "0");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that's fine for this.

@incrypto32
Copy link
Member Author

@lutter apologies for the late reply, i dont remember exactly what the case was but it happens only when running graphman query on query node since this env var is set only on query node enabling load management, but graphman tries to enable load manager with empty values unlike graph-node which has the full config so graphman query just fails. So i just disabled it for graphman, i hope its fine to do that since in the same container graph-node runs.

But graph-node loads its env vars on startup and dont care about it again. Let me know if its ok to keep it this way

@incrypto32 incrypto32 force-pushed the krishna/fix-graphman-query branch 2 times, most recently from 4fcd82c to 7f1ed00 Compare March 27, 2025 12:01
@incrypto32 incrypto32 force-pushed the krishna/fix-graphman-query branch from 7f1ed00 to 2e2872a Compare April 7, 2025 11:48
@incrypto32 incrypto32 merged commit c765ce7 into master Apr 7, 2025
6 checks passed
@incrypto32 incrypto32 deleted the krishna/fix-graphman-query branch April 7, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphman query command not working on query-node
2 participants