-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphman: disable load management when using graphman #5875
Conversation
@@ -1030,6 +1031,9 @@ impl Context { | |||
|
|||
#[tokio::main] | |||
async fn main() -> anyhow::Result<()> { | |||
// Disable load management for graphman commands | |||
env::set_var("GRAPH_LOAD_THRESHOLD", "0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't want to add a boolean flag in LoadManager::new
just for this, so just hardset the env var here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's fine for this.
2e4ef20
to
7f1ed00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, how was the load manager interfering with graphman query
?
@@ -1030,6 +1031,9 @@ impl Context { | |||
|
|||
#[tokio::main] | |||
async fn main() -> anyhow::Result<()> { | |||
// Disable load management for graphman commands | |||
env::set_var("GRAPH_LOAD_THRESHOLD", "0"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's fine for this.
@lutter apologies for the late reply, i dont remember exactly what the case was but it happens only when running But graph-node loads its env vars on startup and dont care about it again. Let me know if its ok to keep it this way |
4fcd82c
to
7f1ed00
Compare
7f1ed00
to
2e2872a
Compare
Closes #5850