Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of Altair UI settings #1044

Conversation

Sonic198
Copy link
Contributor

@Sonic198 Sonic198 commented Jul 1, 2023

Add support for Altair UI settings

@Shane32
Copy link
Member

Shane32 commented Jul 1, 2023

Looks good. You’ll need to run the api tests so that the approval file is updated and CI tests pass.

I assume you tested this PR and the changes work sufficiently for your needs?

@Sonic198
Copy link
Contributor Author

Sonic198 commented Jul 1, 2023

you

Looks good. You’ll need to run the api tests so that the approval file is updated and CI tests pass.

I assume you tested this PR and the changes work sufficiently for your needs?

You mean I need to run tests locally from VS?
Yes, I tested it, works well for me.

@Shane32
Copy link
Member

Shane32 commented Jul 1, 2023

You mean I need to run tests locally from VS?

Yes. It will update an approval file; just commit the changed file and push.

@Shane32
Copy link
Member

Shane32 commented Jul 1, 2023

@sungam3r Do you want to review? I'll merge/release tomorrow otherwise.

@codecov-commenter
Copy link

Codecov Report

Merging #1044 (d9a8c86) into master (81e953a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master    #1044   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          44       44           
  Lines        2180     2180           
  Branches      367      367           
=======================================
  Hits         2037     2037           
  Misses        102      102           
  Partials       41       41           

@Shane32 Shane32 changed the title Altair UI Settings Allow configuration of Altair UI settings Jul 2, 2023
@Shane32 Shane32 merged commit 312a860 into graphql-dotnet:master Jul 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants