Update samples and tests for .NET 8 #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Shane32
commented
Jan 12, 2024
•
Shane32
commented
- Sample and test projects now target .NET 8
- Test project dependencies are updated to work with .NET 8
- Minor code changes to tests to fix new .NET 8 SDK analyzer violations
- Patch for UseAuthorization does not work with WebHostBuilder on .NET 8 dotnet/aspnetcore#53332 within a test
- Fixed existing obsolete description.
- Update CI workflows to install/use the .NET 8 SDK
- No changes at all to main library.
Shane32
commented
Jan 12, 2024
| @@ -29,6 +29,7 @@ private TestServer CreateServer(Action<IServiceCollection>? configureServices = | |||
| .AddAutoSchema<Chat.Query>() | |||
| .AddErrorInfoProvider(new CustomErrorInfoProvider(this)) | |||
| .AddSystemTextJson()); | |||
| services.AddRouting(); | |||
There was a problem hiding this comment.
Shane32
commented
Jan 12, 2024
| @@ -8,7 +8,7 @@ namespace GraphQL.Server.Authorization.AspNetCore; | |||
| public partial class AuthorizationValidationRule | |||
| { | |||
| /// <inheritdoc/> | |||
| [Obsolete("This class has been replaced by GraphQL.Server.Transports.AspNetCore.AuthorizationValidationRule.AuthorizationVisitor and will be removed in v8.")] | |||
| [Obsolete("This class has been replaced by GraphQL.Server.Transports.AspNetCore.AuthorizationVisitor and will be removed in v8.")] | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 45 45
Lines 2215 2215
Branches 375 375
=======================================
Hits 2070 2070
Misses 103 103
Partials 42 42 ☔ View full report in Codecov by Sentry. |
gao-artur
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.