-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples and tests for .NET 8 #1107
Conversation
Shane32
commented
Jan 12, 2024
•
edited
Loading
edited
- Sample and test projects now target .NET 8
- Test project dependencies are updated to work with .NET 8
- Minor code changes to tests to fix new .NET 8 SDK analyzer violations
- Patch for UseAuthorization does not work with WebHostBuilder on .NET 8 dotnet/aspnetcore#53332 within a test
- Fixed existing obsolete description.
- Update CI workflows to install/use the .NET 8 SDK
- No changes at all to main library.
@@ -29,6 +29,7 @@ private TestServer CreateServer(Action<IServiceCollection>? configureServices = | |||
.AddAutoSchema<Chat.Query>() | |||
.AddErrorInfoProvider(new CustomErrorInfoProvider(this)) | |||
.AddSystemTextJson()); | |||
services.AddRouting(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -8,7 +8,7 @@ namespace GraphQL.Server.Authorization.AspNetCore; | |||
public partial class AuthorizationValidationRule | |||
{ | |||
/// <inheritdoc/> | |||
[Obsolete("This class has been replaced by GraphQL.Server.Transports.AspNetCore.AuthorizationValidationRule.AuthorizationVisitor and will be removed in v8.")] | |||
[Obsolete("This class has been replaced by GraphQL.Server.Transports.AspNetCore.AuthorizationVisitor and will be removed in v8.")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed reference
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
=======================================
Coverage 93.45% 93.45%
=======================================
Files 45 45
Lines 2215 2215
Branches 375 375
=======================================
Hits 2070 2070
Misses 103 103
Partials 42 42 ☔ View full report in Codecov by Sentry. |