Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to file-scoped namespaces #773

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Change to file-scoped namespaces #773

merged 1 commit into from
Apr 14, 2022

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Apr 14, 2022

This PR contains no changes other than conversion to file-scoped namespaces, so as to reduce diff for future changes.

@Shane32
Copy link
Member Author

Shane32 commented Apr 14, 2022

Use 'hide whitespace' to view reduce diff in GitHub preview.

@codecov-commenter
Copy link

Codecov Report

Merging #773 (aab2e1b) into develop (ce77ad1) will not change coverage.
The diff coverage is 48.62%.

@@           Coverage Diff            @@
##           develop     #773   +/-   ##
========================================
  Coverage    47.93%   47.93%           
========================================
  Files           50       50           
  Lines         1552     1552           
  Branches       174      174           
========================================
  Hits           744      744           
  Misses         752      752           
  Partials        56       56           
Impacted Files Coverage Δ
...spNetCore/GraphQLBuilderAuthorizationExtensions.cs 0.00% <0.00%> (ø)
.../Extensions/GraphQLBuilderUserContextExtensions.cs 0.00% <0.00%> (ø)
...sions/GraphQLHttpEndpointRouteBuilderExtensions.cs 0.00% <0.00%> (ø)
...AspNetCore/GraphQLDefaultEndpointSelectorPolicy.cs 0.00% <0.00%> (ø)
src/Transports.AspNetCore/UserContextBuilder.cs 0.00% <0.00%> (ø)
...GraphQLWebSocketsEndpointRouteBuilderExtensions.cs 0.00% <0.00%> (ø)
...ts.Subscriptions.WebSockets/WebSocketConnection.cs 0.00% <0.00%> (ø)
...criptions.WebSockets/WebSocketConnectionFactory.cs 0.00% <0.00%> (ø)
...ubscriptions.WebSockets/WebSocketReaderPipeline.cs 0.00% <0.00%> (ø)
...rts.Subscriptions.WebSockets/WebSocketTransport.cs 0.00% <0.00%> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce77ad1...aab2e1b. Read the comment docs.

@Shane32 Shane32 added code style Pull request that applies code style rules and removed performance test labels Apr 14, 2022
@sungam3r
Copy link
Member

It will break all PRs. I intentionally did not change namespaces. Or do you mean that all current PRs will be rejected or solved by further changes?

@Shane32
Copy link
Member Author

Shane32 commented Apr 14, 2022

Well..... uhhh.... I dunno. I just am trying to help you review my PR(s).

#733 -- needs to be redone in light of serialization libraries have been moved to GraphQL.NET repo - most likely this code needs to be added to GraphQL.NET repo
#694 -- obsolete with my new subscription code
#587 -- only contains a couple lines of code that were changed
#515 -- one file is new; the other is easily merged with any changes
#279 -- obsolete with my new subscription code
#195 -- this is 3 years old now

@Shane32 Shane32 merged commit e8f2f38 into develop Apr 14, 2022
@Shane32 Shane32 deleted the file_scoped_namespaces branch April 14, 2022 18:54
@sungam3r sungam3r added this to the v6 milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style Pull request that applies code style rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants