feat: preflight scripts for laboratory #5564
Conversation
- [ ] replace by `app/feed.xml/route.ts` route handler - [ ] remove `graymatter` dependency - [ ] refactor `product-updates` to allow to have changelog as folder
| supertokens: | ||
| ports: | ||
| - '3567:3567' |
There was a problem hiding this comment.
needs to be exposed for the seed script
| @@ -131,6 +131,7 @@ const createSession = async ( | |||
| */ | |||
| return { | |||
| access_token: data.accessToken.token, | |||
| refresh_token: data.refreshToken.token, | |||
There was a problem hiding this comment.
we need this in cypress for "logging" in the user
| const pg = { | ||
| user: ensureEnv('POSTGRES_USER'), | ||
| password: ensureEnv('POSTGRES_PASSWORD'), | ||
| host: ensureEnv('POSTGRES_HOST'), | ||
| port: ensureEnv('POSTGRES_PORT'), | ||
| db: ensureEnv('POSTGRES_DB'), | ||
| }; |
There was a problem hiding this comment.
Delaying this assertion because it is not required for seeding within the e2e tests.
There was a problem hiding this comment.
Inspired by @jasonkuhrt I tried some namespace action. 😄
I kind of like that types are isolated.
There was a problem hiding this comment.
@n1ru4l @dotansimha per some of our other recent discussions, one limitation of TS namespace UNLIKE ESM is that you cannot export * from .... Its a significant limitation in some cases, enough not to use them (for example consider my Typebox namespace in my PR). Another reason to not use them, as mentioned before, is that, again UNLIKE ESM, namespace does not support tree shaking since its actually not a static ECMA feature.
As previously mentioned, IMO the nirvana would be the tc39 inline modules spec (assuming it does what I think it will do haha). It would decouple the concept of module and file, replacing all the use-cases of namespace, while bringing symmetry with ESM such as the aforementioned export * from ... and tree shaking (should, since its a static structure, so bundlers should be able to track it just like they do with ESM file-modules today).
Also, currently, TS unfortunately has poor autocomplete for ESM based namespaces. Truly annoying because it means we are stuck, in some cases, between this choice:
- Good IDE experience
- Good runtime characteristics (tree shaking namely)
Anyways, I'm pretty passionate and nerdy about this stuff as you can see... 🫶. My interest comes from my belief that namespaces are hugely important to maintainable and readable code.
This reverts commit fc178c0.
n1ru4l
changed the title
closes #3612
Preview Link for docs: #5564 (comment)