Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multipart requests / file uploads #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rshk
Copy link

@rshk rshk commented Jul 24, 2018

Requests with multipart/form-data were handled incorrectly, preventing file upload functionality from working.

I fixed GraphQLView to support file uploads according to the specification.

This is currently used in production to receive file uploads via apollo-upload-client.

Haven't really tested on Py2 or <3.6, test suite seems to be happy though.

@rshk rshk mentioned this pull request Jul 24, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-9.3%) to 84.247% when pulling 84583cf on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@coveralls
Copy link

coveralls commented Jul 24, 2018

Coverage Status

Coverage increased (+1.07%) to 94.615% when pulling 9e69073 on rshk:support-multipart-requests into 4183613 on graphql-python:master.

@rshk rshk force-pushed the support-multipart-requests branch from 84583cf to c67fc48 Compare July 24, 2018 21:51
@rshk rshk force-pushed the support-multipart-requests branch from 5aafca9 to 52e647f Compare July 25, 2018 12:20
@Fenkiou
Copy link

Fenkiou commented Mar 18, 2019

Any update on this?

@sabard
Copy link

sabard commented Aug 2, 2019

I've been using graphene-file-upload for now. Code looks to be doing pretty much the same thing as this.

Will be nice to consolidate when this gets merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants