refactor: use exeContext strategically#3654
Merged
yaacovCR merged 2 commits intographql:mainfrom Jun 21, 2022
Merged
Conversation
`operation` is included within `exeContext`
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
added
the
PR: polish 💅
saihaj
approved these changes
Jun 20, 2022
IvanGoncharov
approved these changes
Jun 21, 2022
Member
IvanGoncharov
left a comment
IvanGoncharov
left a comment
There was a problem hiding this comment.
In our current code base, this change makes a lot of sense.
Before this change, we passed the same data in two different ways.
That said I'm not in favor of one "mega argument" as we have in exeContext but that requires different separate refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
executeOperationcan take only one parameter,operationis included withinexeContextexeContext@IvanGoncharov this is a small hopefully straightforward PR that can be merged (as two separate commits or as a squashed commit if you would prefer) if #3639 or #3644 are blocked.