Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Implementation of June 2023 incremental delivery format with @defer #1074

Draft
wants to merge 13 commits into
base: benjie/incremental-common
Choose a base branch
from
Draft

[RFC] Implementation of June 2023 incremental delivery format with @defer #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7adde84
Extract common logic from ExecuteQuery, ExecuteMutation and ExecuteSu…
benjie Apr 28, 2023
54e4b9f
Change ExecuteSelectionSet to ExecuteGroupedFieldSet
benjie Apr 28, 2023
b342b58
Correct reference to MergeSelectionSets
benjie Aug 21, 2023
821b537
Apply edits
benjie Apr 28, 2023
dd930a2
Move algorithm
benjie Apr 28, 2023
0f5e0a8
Various fixes
benjie Apr 28, 2023
4aac505
Minor editorial and fixes
benjie Feb 5, 2024
c26be65
Consistency
benjie Feb 5, 2024
629f6fb
New algorithm using streams, graphs and partitions
benjie Feb 6, 2024
b0530f7
More of the execution algorithm
benjie Feb 6, 2024
d1f8218
Remove stream
benjie Feb 6, 2024
efe3cd2
Fix
benjie Feb 6, 2024
6dc9489
rr
benjie Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/Section 5 -- Validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ unambiguous. Therefore any two field selections which might both be encountered
for the same object are only valid if they are equivalent.

During execution, the simultaneous execution of fields with the same response
name is accomplished by {MergeSelectionSets()} and {CollectFields()}.
name is accomplished by {CollectSubfields()}.

For simple hand-written GraphQL, this rule is obviously a clear developer error,
however nested fragments can make this difficult to detect manually.
Expand Down
Loading
Loading