When sourceStream errors, raise an error payload instead
#1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favour of an inline edit |
|
Re-opened since #1099 is editorial whereas this is a behavioural change. |
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/graphql/graphql-spec/pull/1099/files#r1799509253
Currently if
sourceStreamgenerates an error, thenresponseStreamrepeats the error. This is the behavior implemented in graphql-js and is problematic.GraphQL captures execution errors and wraps them in an
{ errors: [...] }payload for query and mutation operations; it should do the same for stream errors in a subscription operation.This PR makes this change. It is technically a breaking change, I think, so will require careful thought.