Distinguish between executing (a selection set) vs processing (a response)#1154
Closed
martinbonnin wants to merge 5 commits intographql:benjie/incremental-commonfrom
Closed
Distinguish between executing (a selection set) vs processing (a response)#1154martinbonnin wants to merge 5 commits intographql:benjie/incremental-commonfrom
martinbonnin wants to merge 5 commits intographql:benjie/incremental-commonfrom
Conversation
martinbonnin
changed the title
martinbonnin
changed the title
martinbonnin
force-pushed
the
clarify-execution
branch
from
370fa75 to
5c2ad6a
Compare
BoD
approved these changes
Apr 3, 2025
Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>
Co-authored-by: Benoit 'BoD' Lubek <BoD@JRAF.org>
mjmahone
approved these changes
Apr 3, 2025
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
Yeah this makes the difference between "processing" stage vs "execution" stage much more clear, and I like this pull-apart.
leebyron
reviewed
Apr 3, 2025
benjie
force-pushed
the
benjie/incremental-common
branch
2 times, most recently
from
6e76340 to
3c6dfb3
Compare
Contributor
Author
|
Closing as this has been incorporated in #894 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #1039 ("Replace ExecuteSelectionSet with ExecuteGroupedFieldSet")
See context in #1152 (comment) and #894
This PR clarifies that execution is for selection sets and fields. Requests and operations are "processed" instead.
This is especially important for subscription that will execute their root selection set multiple times. It's also in line with variable coercion errors being "request errors" and not "execution errors"