141 warning if volunteer info is missing #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Deployed to the admin-portal-pr-160 environment in Grassroots Grocery Admin Portal
|
mattsahn
reviewed
Aug 15, 2024
| @@ -375,7 +473,6 @@ export const VolunteersTable: React.FC<{ | |||
| "Participant Type", | |||
| "Confirmed", | |||
| "Can't Come", | |||
| "Past Events", | |||
There was a problem hiding this comment.
The recently added "Past Events" column is missing from this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this change
Added small warning symbol next to first names if missing any info (i.e any of the scheduledslots types were undefined). Additionally added an export function that keeps count of these warnings. Used this function to add a counter on the top of each event in red
Screenshots (for UI changes - otherwise delete this section)
Before this PR:
After this PR:
(warnings are from changing if statement from if typeof participanType is undefined to if participantType is driver. Pull request will not show any warnings)