Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set min macOS version to 11 #46461

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Set min macOS version to 11 #46461

merged 1 commit into from
Oct 4, 2024

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Sep 10, 2024

Go 1.23 has a hard requirement of of macOS11 Big Sur or later.

No backport (for now) as we're only on Go 1.23 on master.

changelog: Teleport requires macOS 11 (Big Sur) or later.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-owgu2wpap-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-lvs8dec37-goteleport.vercel.app/docs/ver/preview

@codingllama
Copy link
Contributor

Note that we have a "MINIMUM_SUPPORTED_MACOS_VERSION" variable on e/ too.

@zmb3
Copy link
Collaborator Author

zmb3 commented Sep 11, 2024

Note that we have a "MINIMUM_SUPPORTED_MACOS_VERSION" variable on e/ too.

Yep, I have it ready to PR locally

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🤖 Vercel preview here: https://docs-h72wgzles-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

🤖 Vercel preview here: https://docs-i7sfswrds-goteleport.vercel.app/docs/ver/preview

@zmb3 zmb3 force-pushed the zmb3/macos11 branch 2 times, most recently from 1d76b21 to 83db581 Compare October 4, 2024 20:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🤖 Vercel preview here: https://docs-ptqbfjg76-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🤖 Vercel preview here: https://docs-9z4j8y0sg-goteleport.vercel.app/docs/ver/preview

@zmb3
Copy link
Collaborator Author

zmb3 commented Oct 4, 2024

Tag build looks good, so I'll merge this now.

➜ ./teleport version
Teleport Enterprise v17.0.0-dev.macos11.4 git:v17.0.0-dev.macos11.4-0-g4f1e948 go1.23.2

➜ vtool -show-build ./teleport
./teleport:
Load command 10
      cmd LC_BUILD_VERSION
  cmdsize 32
 platform MACOS
    minos 11.0
      sdk 14.2
   ntools 1
     tool LD
  version 907.0

@zmb3
Set min macOS version to 11
8a94195 
Go 1.23 has a hard requirement of macOS11 Big Sur or later.
@zmb3 zmb3 enabled auto-merge October 4, 2024 21:55
@zmb3 zmb3 disabled auto-merge October 4, 2024 21:56
@zmb3 zmb3 enabled auto-merge October 4, 2024 21:56
@zmb3 zmb3 added no-changelog Indicates that a PR does not require a changelog entry and removed no-changelog Indicates that a PR does not require a changelog entry labels Oct 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

🤖 Vercel preview here: https://docs-odiren2pp-goteleport.vercel.app/docs/ver/preview

@zmb3 zmb3 added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@zmb3 zmb3 added this pull request to the merge queue Oct 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 4, 2024
@zmb3 zmb3 added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit c8b364e Oct 4, 2024
43 of 45 checks passed
@zmb3 zmb3 deleted the zmb3/macos11 branch October 4, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingllama codingllama codingllama approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
documentation size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmb3 @codingllama @fheinecke @rosstimothy