Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16] tsh: Deduplicate the list of request IDs #47121

Merged
merged 3 commits into from
Oct 4, 2024
Merged

[v16] tsh: Deduplicate the list of request IDs #47121

merged 3 commits into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. tsh: Deduplicate the list of request IDs 

    It's possible to specify the same request multiple times with
tsh request create. The duplicates eventually get resolved before
we generate a certificate, but they do exist in the access request
resource. This can cause the size of the resource to exceed the
limits of a gRPC message and break listing.
    @zmb3
    zmb3 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d804784 View commit details
    Browse the repository at this point in the history

  2. Limit access requests to a maximum of 300 resources

    @zmb3
    zmb3 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    05f24f8 View commit details
    Browse the repository at this point in the history

  3. Only run deduplication when the request is being created

    @zmb3
    zmb3 committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c939999 View commit details
    Browse the repository at this point in the history