Deprecate /webapi/ssh/certs + Use 2-step MFA login flow for Teleport Connect
#47153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
Joerger
changed the title
/webapi/ssh/certs/webapi/ssh/certs + Use 2-step MFA login flow for Teleport Connect
zmb3
approved these changes
Oct 3, 2024
Closed
Joerger
force-pushed
the
joerger/deprectate-password-login-endpoint
branch
from
c7bc384
to
515cd9b
Compare
…rom Teleport Connect.
Joerger
force-pushed
the
joerger/deprectate-password-login-endpoint
branch
from
515cd9b
to
20d569d
Compare
rosstimothy
approved these changes
Oct 4, 2024
public-teleport-github-review-bot
bot
removed request for
ryanclark and
flyinghermit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
/webapi/ssh/certsin favor of/webapi/mfa/login/begin+finishand new/webapi/headless/loginendpoints.Now that MFA cannot be disabled or made optional, we can always use the mfa login flow. This allows us to make clients stupider - remove a bunch of
second_factorswitches and instead just use whatever MFA challenge the server provides.This also results in an arguably nicer 2-step login flow for OTP, matching the current Webauthn flow. See this slack thread for discussion + new Teleport Connect demo.
Changelog: Use 2-step OTP login flow for Teleport Connect.