Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace EOL Debian Buster with Bullseye in Dockerfile-node #47204

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Replace EOL Debian Buster with Bullseye in Dockerfile-node #47204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b13a04
Use Debian Bullseye instead of EOL Debian Buster
gzdunek Oct 4, 2024
ab8ad34
Update Node.js to 20.17
gzdunek Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions build.assets/Dockerfile-node
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,18 @@
# to build the Teleport Connect. It can also be used to build the
# web assets for the Teleport UI.
#
# This image is base on the node image, which is based on Debian Buster.
# Using it as a image allows us to link agains the same version of
# glibc as Node.js.
# This image is base on the node image, which is based on Debian Bullseye.
# Using it as an image allows us to link against the oldest version of glibc
# supported by Node.js Docker images.
#
# Check the README to learn how to safely introduce changes to Dockerfiles.

## BUILDBOX-NODE ###################################################################

# Pin the tag to Debian Buster to make sure the Glibc compatibility.
# Pin the tag to Debian Bullseye to make sure the glibc compatibility
# (glibc version of Bullseye is 2.31).
ARG NODE_VERSION
FROM node:${NODE_VERSION}-buster AS buildbox
FROM node:${NODE_VERSION}-bullseye AS buildbox

# BUILDARCH is automatically set by DOCKER when building the image with Build Kit (MacOS by deafult).
# https://docs.docker.com/engine/reference/builder/#automatic-platform-args-in-the-global-scope
Expand Down
2 changes: 1 addition & 1 deletion build.assets/versions.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
GOLANG_VERSION ?= go1.23.2
GOLANGCI_LINT_VERSION ?= v1.61.0

NODE_VERSION ?= 20.14.0
NODE_VERSION ?= 20.17.0

# Run lint-rust check locally before merging code after you bump this.
RUST_VERSION ?= 1.81.0
Expand Down
Loading