[v15] Fix flaky integrations tests #47217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In these tests, the events and error channels are closed at approximately the same time. If the test's select statement sees the closure of the error channel first, then it will see a nil error. This should not be considered a test failure, as there was no error.
zmb3
added
the
no-changelog
github-actions
bot
requested review from
marcoandredinis,
rosstimothy and
tigrato
tigrato
approved these changes
Oct 4, 2024
rosstimothy
approved these changes
Oct 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from marcoandredinis
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2024
In these tests, the events and error channels are closed at approximately the same time. If the test's select statement sees the closure of the error channel first, then it will see a nil error. This should not be considered a test failure, as there was no error.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #47180 to branch/v15