-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Am 702 #2846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just finished commit 4 so far 😅
I'll pick up from there later
...avitee-am-reporter-jdbc/src/main/java/io/gravitee/am/reporter/jdbc/dialect/MSSQLDialect.java
Outdated
Show resolved
Hide resolved
...ider/gravitee-am-identityprovider-jdbc/src/main/java/io/r2dbc/mssql/codec/DefaultCodecs.java
Outdated
Show resolved
Hide resolved
...rc/main/java/io/gravitee/am/repository/jdbc/provider/template/CustomR2dbcEntityTemplate.java
Outdated
Show resolved
Hide resolved
6e79d66
to
c3db1e8
Compare
related-to AM-702
…assertEmpty. This will avoid flaky tests and more importantly really test what we want as a behaviour
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped half way. It's hard to review this upgrades. Since there aren't any functional improvements, in my opinion if the CI is green, we can merge.
There will be a full regression pack to make sure that we didn't miss anything else.
Fix AM-702
Description
This PR upgrade AM to use the latest gravitee-bom & gravitee-parent.
It is by extension the migration to Spring 6.
This PR is split in different commit, to track the different changes made along the issues we meet during this migration.
Main impacts / changes:
How to test
please run the full non regression pack on nightly env (Mongo & JDBC one)
Documentation inputs
For information, previous values were:
Here is the versions we used for the R2DBC drivers
postgresql : 1.0.2.RELEASE
mariadb: 1.1.2
mysql: 1.0.2
mssql : 1.0.0.RELEASE
WARNING⚠️ DO NOT use the 1.0.2.RELEASE for mssql / SQLServer as this version seems to be buggy (see r2dbc/r2dbc-mssql#276)
Note: could be nice to have the new default settings and the R2DBC driver version in the Repository page