Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-index search query for logs #10608

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

jourdiw
Copy link
Contributor

@jourdiw jourdiw commented Feb 7, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-6236

Description

Search across the request + metrics indexes in order to have paginated results for all APIs.

Next PRs:

  • Service layer + use cases
  • Return list to PAPI
  • Get log detail of V4 API for portal
  • Handle Portal-Next UI for V4 APIs
  • Handle Portal UI for V4 APIs

Additional context


📚  View the storybook of this branch here

@jourdiw jourdiw force-pushed the apim-6236-portal-application-logs-v2-and-v4 branch 2 times, most recently from 26078e3 to 2ea1499 Compare February 10, 2025 17:44
@jourdiw jourdiw changed the title Return v2 + v4 application logs for portal Multi-index search query for logs Feb 10, 2025
@jourdiw jourdiw marked this pull request as ready for review February 10, 2025 18:15
@jourdiw jourdiw requested a review from a team as a code owner February 10, 2025 18:15
@jourdiw jourdiw requested a review from Okhelifi February 10, 2025 18:15
Copy link
Member

@phiz71 phiz71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍🏻 .
I've put some comments to be discussed

@jourdiw jourdiw force-pushed the apim-6236-portal-application-logs-v2-and-v4 branch 2 times, most recently from 27854b6 to a4f609d Compare February 11, 2025 13:34
Copy link

cypress bot commented Feb 11, 2025

APIM UI Tests    Run #3707

Run Properties:  status check failed Failed #3707  •  git commit a4f609d78a: feat(repository): handle searching multiple indexes depending upon api definitio...
Project APIM UI Tests
Branch Review apim-6236-portal-application-logs-v2-and-v4
Run status status check failed Failed #3707
Run duration 07m 01s
Commit git commit a4f609d78a: feat(repository): handle searching multiple indexes depending upon api definitio...
Committer jourdiw
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 80
View all changes introduced in this branch ↗︎

Tests for review

Failed  ui-test/integration/apim/ui/organization-settings/ui-users.spec.ts • 2 failed tests

View Output Video

Test Artifacts
Users > should create a new user Test Replay Screenshots Video
Users > should create a new service account user Test Replay Screenshots Video

@jourdiw jourdiw requested a review from phiz71 February 11, 2025 14:36
Copy link
Member

@Okhelifi Okhelifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍🏼

@jourdiw jourdiw force-pushed the apim-6236-portal-application-logs-v2-and-v4 branch from a4f609d to 2cddb28 Compare February 11, 2025 15:49
@jourdiw jourdiw enabled auto-merge (rebase) February 11, 2025 15:51
@jourdiw jourdiw merged commit 239f6cc into master Feb 11, 2025
26 checks passed
@jourdiw jourdiw deleted the apim-6236-portal-application-logs-v2-and-v4 branch February 11, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants