-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-index search query for logs #10608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26078e3
to
2ea1499
Compare
phiz71
reviewed
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍🏻 .
I've put some comments to be discussed
...e/repository/elasticsearch/v4/log/adapter/connection/SearchConnectionLogResponseAdapter.java
Outdated
Show resolved
Hide resolved
...itee/repository/elasticsearch/v4/log/adapter/connection/SearchConnectionLogQueryAdapter.java
Outdated
Show resolved
Hide resolved
...e/repository/elasticsearch/v4/log/adapter/connection/SearchConnectionLogResponseAdapter.java
Outdated
Show resolved
Hide resolved
27854b6
to
a4f609d
Compare
APIM UI Tests
|
Project |
APIM UI Tests
|
Branch Review |
apim-6236-portal-application-logs-v2-and-v4
|
Run status |
|
Run duration | 07m 01s |
Commit |
|
Committer | jourdiw |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
0
|
|
8
|
|
0
|
|
80
|
View all changes introduced in this branch ↗︎ |
Tests for review
ui-test/integration/apim/ui/organization-settings/ui-users.spec.ts • 2 failed tests
Test | Artifacts | |
---|---|---|
Users > should create a new user |
Test Replay
Screenshots
Video
|
|
Users > should create a new service account user |
Test Replay
Screenshots
Video
|
jgiovaresco
reviewed
Feb 11, 2025
...pository-api/src/main/java/io/gravitee/repository/log/v4/model/connection/ConnectionLog.java
Show resolved
Hide resolved
...ch/src/main/java/io/gravitee/repository/elasticsearch/v4/log/LogElasticsearchRepository.java
Outdated
Show resolved
Hide resolved
Okhelifi
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👍🏼
a4f609d
to
2cddb28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-6236
Description
Search across the request + metrics indexes in order to have paginated results for all APIs.
Next PRs:
Additional context
📚 View the storybook of this branch here