-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.6.x] fix: access public APIs listed in a category when user is logged out #10643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of e9e04a9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Signed-off-by: aditya.goyal <[email protected]> (cherry picked from commit e9e04a9)
418b68f
to
f563188
Compare
Okhelifi
approved these changes
Feb 12, 2025
APIM UI Tests
|
Project |
APIM UI Tests
|
Branch Review |
mergify/bp/4.6.x/pr-10636
|
Run status |
|
Run duration | 07m 07s |
Commit |
|
Committer | Aditya Goyal |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
2
|
|
0
|
|
8
|
|
0
|
|
80
|
View all changes introduced in this branch ↗︎ |
Tests for review
ui-test/integration/apim/ui/organization-settings/ui-users.spec.ts • 2 failed tests
Test | Artifacts | |
---|---|---|
Users > should create a new user |
Test Replay
Screenshots
Video
|
|
Users > should create a new service account user |
Test Replay
Screenshots
Video
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic copy of pull request #10636 done by Mergify.
Issue
https://gravitee.atlassian.net/browse/APIM-8384
Description
Allow access to public APIs listed in a category when user logged out.
Additional context
This is the second PR raised to fix the same bug because of following reasons:
GetCategoryApisUseCase
already handled the scenario to display public APIs in a category when the user id is null. We were just not passing the null id as the input to the use case.📚 View the storybook of this branch here
Cherry-pick of e9e04a9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
📚 View the storybook of this branch here