Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.5.x] fix: access public APIs listed in a category when user is logged out #10644

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 12, 2025

This is an automatic copy of pull request #10636 done by Mergify.


Issue

https://gravitee.atlassian.net/browse/APIM-8384

Description

Allow access to public APIs listed in a category when user logged out.

Additional context

This is the second PR raised to fix the same bug because of following reasons:

  1. First one failed to pass some tests on earlier versions i.e. 4.4.x, 4.5.x. It passed the checks on 4.6.x and master.
  2. After the discussion, it came to light that the GetCategoryApisUseCase already handled the scenario to display public APIs in a category when the user id is null. We were just not passing the null id as the input to the use case.

📚  View the storybook of this branch here



📚  View the storybook of this branch here

@mergify mergify bot requested a review from a team as a code owner February 12, 2025 17:02
Copy link

cypress bot commented Feb 12, 2025

APIM UI Tests    Run #3721

Run Properties:  status check passed Passed #3721  •  git commit 899a93eb31: fix: Access public APIs listed in a category when user is logged out
Project APIM UI Tests
Branch Review mergify/bp/4.5.x/pr-10636
Run status status check passed Passed #3721
Run duration 07m 04s
Commit git commit 899a93eb31: fix: Access public APIs listed in a category when user is logged out
Committer Aditya Goyal
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 8
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 82
View all changes introduced in this branch ↗︎

@Okhelifi Okhelifi merged commit 09e5b38 into 4.5.x Feb 12, 2025
47 of 50 checks passed
@Okhelifi Okhelifi deleted the mergify/bp/4.5.x/pr-10636 branch February 12, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants