Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): remove nginx configuration-snippet by default #10646

Merged
merged 1 commit into from
Feb 14, 2025
+3 −4
Merged

feat(helm): remove nginx configuration-snippet by default #10646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions helm/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ This file documents all notable changes to [Gravitee.io API Management 3.x](http
### 4.3.23

- fix typo and indentation about mapping of user.anonymize-on-delete.enabled (APIM-8628)
- remove nginx `configuration-snippet` by default (APIM-8630)

### 4.3.21

Expand Down
1 change: 1 addition & 0 deletions helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,4 @@ annotations:
###########
artifacthub.io/changes: |
- 'fix typo and indentation about mapping of user.anonymize-on-delete.enabled (APIM-8628)'
- 'remove nginx `configuration-snippet` by default (APIM-8630)'
5 changes: 1 addition & 4 deletions helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ api:
- apim.example.com
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/configuration-snippet: "etag on;\nproxy_pass_header ETag;\nproxy_pass_header if-match;\n"
#nginx.ingress.kubernetes.io/configuration-snippet: "etag on;\nproxy_pass_header ETag;\nproxy_pass_header if-match;\n"
# kubernetes.io/tls-acme: "true"
# tls:
# Secrets must be manually created in the namespace.
Expand All @@ -733,7 +733,6 @@ api:
- apim.example.com
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/configuration-snippet: "etag on;\nproxy_pass_header ETag;\nproxy_set_header if-match \"\";\n"
# kubernetes.io/tls-acme: "true"
# tls:
# Secrets must be manually created in the namespace.
Expand Down Expand Up @@ -1375,7 +1374,6 @@ portal:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /
nginx.ingress.kubernetes.io/configuration-snippet: "etag on;\nproxy_pass_header ETag;\n"
#tls:
# Secrets must be manually created in the namespace.
# - hosts:
Expand Down Expand Up @@ -1572,7 +1570,6 @@ ui:
annotations:
kubernetes.io/ingress.class: nginx
nginx.ingress.kubernetes.io/rewrite-target: /$1
nginx.ingress.kubernetes.io/configuration-snippet: "etag on;\nproxy_pass_header ETag;\n"
# tls:
# Secrets must be manually created in the namespace.
# - hosts:
Expand Down