Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): log all API calls including unauthorized (401) requests #11175

Merged

Conversation

ankita-gupta21
Copy link
Contributor

@ankita-gupta21 ankita-gupta21 commented Mar 19, 2025

Issue

https://gravitee.atlassian.net/browse/APIM-7232

Description

Fixed this by aggregation on status_ranges and entrypoint_id, ensuring all response codes are logged, including those that fail at the gateway.

Additional context

Before

Screenshot 2025-03-19 at 12 27 39 PM

After

Screenshot 2025-03-19 at 12 18 05 PM
Screen.Recording.2025-03-25.at.3.12.57.PM.mov

📚  View the storybook of this branch here

@ankita-gupta21 ankita-gupta21 requested review from a team as code owners March 19, 2025 07:06
@ankita-gupta21 ankita-gupta21 changed the base branch from master to 4.4.x March 19, 2025 07:06
@ankita-gupta21 ankita-gupta21 force-pushed the APIM-7232-fix-api-analytics-render-in-console-ui branch 3 times, most recently from 8e5fc6c to 9807b2c Compare March 19, 2025 07:48
Copy link
Contributor

@ThibaudAV ThibaudAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the corresponding test? so that with the previous code the test doesn't pass and with the correction it does?

@ankita-gupta21 ankita-gupta21 force-pushed the APIM-7232-fix-api-analytics-render-in-console-ui branch 2 times, most recently from 4d228b4 to d538146 Compare March 25, 2025 06:49
@ankita-gupta21
Copy link
Contributor Author

Could you update the corresponding test? so that with the previous code the test doesn't pass and with the correction it does?

So i already had a PR where i added a test case. This is the link for reference
#10938

@ankita-gupta21 ankita-gupta21 force-pushed the APIM-7232-fix-api-analytics-render-in-console-ui branch 5 times, most recently from 3d595b2 to e34db64 Compare March 27, 2025 12:02
@ankita-gupta21 ankita-gupta21 force-pushed the APIM-7232-fix-api-analytics-render-in-console-ui branch from e34db64 to 4420c6c Compare March 28, 2025 15:00
@ankita-gupta21 ankita-gupta21 merged commit 08780ba into 4.4.x Mar 28, 2025
25 of 26 checks passed
@ankita-gupta21 ankita-gupta21 deleted the APIM-7232-fix-api-analytics-render-in-console-ui branch March 28, 2025 15:42
@ankita-gupta21 ankita-gupta21 added apply-on-4-5-x apply-on-4-6-x ready_to_test Push the code from the PR into a dedicated environment labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apply-on-4-5-x apply-on-4-6-x ready_to_test Push the code from the PR into a dedicated environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants