fix: tidy up project (wip) #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benoitgravitee
commented
Mar 18, 2025
benoitgravitee
commented
- move package markers to dedicated files
- move tooling related files to tooling/
- move indexer to search package
- update linters
- add prettier check for scripts
- fix make helm-test
benoitgravitee
force-pushed
the
fix-tidy-up-project
branch
15 times, most recently
from
fe41ffd to
19ccbf1
Compare
|
could/should we use the hack package to put tooling / binary version management ? It looks like this what the kubernetes project does https://pkg.go.dev/k8s.io/kubernetes/hack |
- use a specific file for package level markers - move tooling related files to "tooling" directory - remove lint execution warnings, uncomment those who pass - move indexer to search package - reformat scripts - add script linting (prettier format check) - make helm-test - manage tools with go mod - update CI for tooling
benoitgravitee
force-pushed
the
fix-tidy-up-project
branch
from
8d7b511 to
0d16dff
Compare
|
a-cordier
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.