Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NET-887): show reason for auth failure #680

Conversation

Aceix
Copy link
Contributor

@Aceix Aceix commented Jan 19, 2024

Describe your changes

this is part of a security fix to prevent non-admin users from registering
Pair with: gravitl/netmaker#2778

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

functions/register_sso.go Outdated Show resolved Hide resolved
this is part of a security fix to prevent non-admin users from registering
@Aceix Aceix force-pushed the kwesi/net-887-bug-0-21-2-0-22-0-high-accounts-of-role-use branch from 75bbfdc to d8ca25d Compare January 25, 2024 12:47
@Aceix Aceix requested a review from abhishek9686 January 25, 2024 12:47
@abhishek9686 abhishek9686 merged commit 08d37f9 into develop Jan 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants