Skip to content

Commit

Permalink
fix: lazy compilation in dev
Browse files Browse the repository at this point in the history
  • Loading branch information
dgaponov committed Jan 28, 2025
1 parent 4a8ec36 commit cf114c6
Show file tree
Hide file tree
Showing 5 changed files with 69 additions and 181 deletions.
214 changes: 48 additions & 166 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,8 @@
"@babel/runtime": "^7.26.0",
"@okikio/sharedworker": "^1.0.7",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.15",
"@rspack/cli": "^1.2.0",
"@rspack/core": "^1.2.0",
"@rspack/dev-server": "^1.0.7",
"@rspack/core": "^1.2.2",
"@rspack/dev-server": "^1.0.10",
"@rspack/plugin-react-refresh": "^1.0.0",
"@statoscope/webpack-plugin": "^5.28.2",
"@svgr/core": "^8.1.0",
Expand Down
5 changes: 3 additions & 2 deletions src/commands/dev/client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async function buildDevServer(config: NormalizedServiceConfig) {
return false;
},
},
liveReload: true,
liveReload: false,
hot: true,
client: {
logging: config.verbose ? 'log' : 'error',
Expand Down Expand Up @@ -153,7 +153,8 @@ async function buildDevServer(config: NormalizedServiceConfig) {
let server: WebpackDevServer | RspackDevServer;

if (bundler === 'rspack') {
const compiler = rspack(rspackConfigs);
// Rspack multicompiler dont work with lazy compilation
const compiler = rspack(rspackConfigs[0]!);

Check warning on line 157 in src/commands/dev/client.ts

View workflow job for this annotation

GitHub Actions / Verify Files

Forbidden non-null assertion
server = new RspackDevServer(options, compiler);
} else {
const compiler = webpack(webpackConfigs);
Expand Down
Loading

0 comments on commit cf114c6

Please sign in to comment.