Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpapf-save-national-format.php: Added new snippet. #1034

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gpapf-save-national-format.php: Added new snippet. #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions gp-advanced-phone-field/gpapf-save-national-format.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?php
/**
* Gravity Perks // Advanced Phone Field // Save Phone Number In National Format
* https://gravitywiz.com/documentation/gravity-forms-advanced-phone-field/
*
* Save the phone number in the national format, rather than international.
*
* For example, rather than a US number saving as +15555551234, the number would be saved as (555) 555-1234.
*/
// Update "123" to your form ID and "4" to your Phone field ID.
add_action( 'gform_save_field_value_123_4', function( $value, $entry, $field, $form, $input_id ) {

if ( ! is_callable( 'gp_advanced_phone_field' ) || ! class_exists( '\libphonenumber\PhoneNumberUtil' ) ) {
return $value;
}

$proto = gp_advanced_phone_field()->get_phone_number_proto( $value );
$phone_number_util = \libphonenumber\PhoneNumberUtil::getInstance();
if ( ! $proto ) {
return $value;
}
return $phone_number_util->format( $proto, \libphonenumber\PhoneNumberFormat::NATIONAL );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add try/catch block for exception handling

The format() method can throw exceptions if the phone number is invalid. Adding a try/catch block would make the code more robust.

-	return $phone_number_util->format( $proto, \libphonenumber\PhoneNumberFormat::NATIONAL );
+	try {
+		return $phone_number_util->format( $proto, \libphonenumber\PhoneNumberFormat::NATIONAL );
+	} catch ( \Exception $e ) {
+		// Log the error if you have a logging system
+		// error_log( 'Error formatting phone number: ' . $e->getMessage() );
+		return $value;
+	}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
return $phone_number_util->format( $proto, \libphonenumber\PhoneNumberFormat::NATIONAL );
try {
return $phone_number_util->format( $proto, \libphonenumber\PhoneNumberFormat::NATIONAL );
} catch ( \Exception $e ) {
// Log the error if you have a logging system
// error_log( 'Error formatting phone number: ' . $e->getMessage() );
return $value;
}


}, 10, 5 );
Loading