gpld-push-min-date-to-next-day-after-set-time.php: Fixed an issue with timezones.

[saifsultanc]

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2875355741/79394

Summary

The snippet above doesn't work, if the site timezone is set to something like Chicago.
Steps to recreate the issue
Here's the video demo of the issue: https://www.loom.com/share/4d5d42b268764351ac52ed29fe69d865?sid=0e71fa96-ff02-4be0-908b-52a85d4ae7b4

We had strtotime( 'midnight tomorrow', $current_time->getTimestamp() ) which caused issues because strtotime() interprets relative times in UTC, which seems to getting incorrect results in different timezones

This fix proposed here ensures that "tomorrow midnight" is correctly calculated in the same timezone as $current_time by using new a DateTime object specifying "tomorrow midnight".

[coderabbitai]

Walkthrough

The change updates the minimum date calculation by replacing the previous use of strtotime('midnight tomorrow', $current_time->getTimestamp()) with the instantiation of a new DateTime object initialized to "tomorrow midnight" in the current timezone. The modified code then retrieves the timestamp from this DateTime object to set the minDate option. There are no changes to any exported or public entities.

Changes

File	Change Summary
gp-limit-dates/gpld-push-min-date-to-next-day-after-set-time.php	Replaced the strtotime('midnight tomorrow') approach with a new DateTime('tomorrow midnight') object to explicitly set the minimum date using timezone.

Sequence Diagram(s)

Loading

sequenceDiagram
    participant C as Caller
    participant F as gp-limit-dates Script
    participant DT as DateTime Object

    C->>F: Request minimum date calculation
    F->>DT: Initialize DateTime('tomorrow midnight') with current timezone
    DT-->>F: Constructed DateTime object
    F->>DT: Retrieve timestamp from DateTime object
    DT-->>F: Return timestamp value
    F-->>C: Return minDate timestamp

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff20239 and cb57472.

📒 Files selected for processing (1)

• gp-limit-dates/gpld-push-min-date-to-next-day-after-set-time.php (1 hunks)

🔇 Additional comments (1)

gp-limit-dates/gpld-push-min-date-to-next-day-after-set-time.php (1)

16-17: Great timezone handling fix!

This change correctly fixes the timezone issue by explicitly creating a DateTime object with 'tomorrow midnight' in the current timezone. The previous implementation likely used strtotime() which interprets relative times in UTC, causing incorrect behavior in different timezones.

The solution ensures that the minimum date will be correctly calculated regardless of the site's timezone setting, which directly addresses the issue demonstrated in the video.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

	Warnings
⚠️	When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against cb57472