Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpcc-copy-label.js: Fixed an issue with copying labels from checkbox selections. #716

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2377837725/55492

Summary

The snippet to copy the label of a choice-based field, when using Copy Cat, doesn't work on a Checkbox field. It only supports Dropdown and radio button fields. This update adds support for the checkbox field.

Screenshot 2023-10-04 at 8 32 10 PM

BEFORE:
https://www.loom.com/share/255f3dbe2e234d9694bf29ce3114a662

AFTER:
https://www.loom.com/share/731daa5781c1404489a290d83336c6ec

gp-copy-cat/gpcc-copy-label.js Outdated Show resolved Hide resolved
gp-copy-cat/gpcc-copy-label.js Outdated Show resolved Hide resolved
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one missing space.

gp-copy-cat/gpcc-copy-label.js Outdated Show resolved Hide resolved
@github-actions
Copy link

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against c0a399c

@claygriffiths claygriffiths merged commit b710306 into master Oct 10, 2023
1 of 2 checks passed
@claygriffiths claygriffiths deleted the saif/fix/55492-checkbox-label-copy branch December 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants