gw-quantity-as-decimal.php: Fixed an issue with Calculation Product field not editable with decimal values.
#720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… field not editable with decimal values.
claygriffiths
requested changes
Oct 17, 2023
Comment on lines
+92
to
+93
| // ensure the quantity min attribute. | ||
| return preg_replace( '/\smin=["\']0["\']/', 'min="0" step="any"', $content ); |
There was a problem hiding this comment.
Nice work on this. Can you make sure it's only targeting the desired fields and not all fields?
See the checks in modify_quantity_input_tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2386150351/55864?folderId=3808239
Summary
https://github.com/gravitywiz/snippet-library/blob/master/gravity-forms/gw-quantity-as-decimal.php
The snippet doesn't work when editing the quantity of a calculated product field on the backend. This happens when the "Output HTML5" setting is enabled on Gravity Forms. On the Calculation field, Gravity Forms runs this logic:
$qty_min_attr = GFFormsModel::is_html5_enabled() ? "min='0'" : '';This adds the
"min='0'"to the input field (For example,<input type="number" name="input_3.3" value="5.2" id="ginput_quantity_305_3" class="ginput_quantity" size="10" min="0">. This field would not be editable with decimal values now.To fix this, we can add the
stepattribute