Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-none-of-the-above-checkbox.js: Fixed an issue with the snippet not working. #722

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2398204713/56361/

Summary

This snippet is not working. A JS error is output into the console on page load.

BEFORE:
Screenshot 2023-10-24 at 5 04 25 PM

AFTER:
Screenshot 2023-10-24 at 5 02 47 PM
Screenshot 2023-10-24 at 5 02 52 PM

@saifsultanc saifsultanc added the bug Something isn't working label Oct 24, 2023
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment for future PRs, as it's a minor performance enhancement.

@github-actions
Copy link

github-actions bot commented Oct 30, 2023

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against a369012

@saifsultanc saifsultanc force-pushed the saif/fix/56361-fix-nota-snippet branch from 6806f7a to 2f4fedc Compare October 30, 2023 01:13
@saifsultanc saifsultanc merged commit 9c85377 into master Oct 30, 2023
@saifsultanc saifsultanc deleted the saif/fix/56361-fix-nota-snippet branch October 30, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants