Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-gravity-forms-rename-uploaded-files.php: Fixed an issue where filename merge tag did not work. #723

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2401416833/56482?folderId=3808239

Summary

The {filename} merge tag doesn't work when using the Rename uploaded files snippet. Inadvertently, we were processing GFCommon::replace_variables on the initial $template after having replaced the {filename} value from it (if present). This update fixes that issue.

THE FORM:
Screenshot 2023-10-28 at 9 20 45 AM

THE SNIPPET SETUP:
Screenshot 2023-10-28 at 9 21 05 AM

THE TEST CASE:
Screenshot 2023-10-28 at 9 21 47 AM

BEFORE:
Screenshot 2023-10-28 at 9 23 24 AM

AFTER:
Screenshot 2023-10-28 at 9 22 30 AM

@saifsultanc saifsultanc added the bug Something isn't working label Oct 28, 2023
@saifsultanc saifsultanc merged commit b992c1d into master Oct 29, 2023
@saifsultanc saifsultanc deleted the saif/fix/56482-rename-uploaded-files branch October 29, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants