gpep-edit-entry.php
: Added support for deleting values for conditionally hidden fields on edit.
#724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2398744738/56383/
Summary
Video Overview: https://www.loom.com/share/152186005083436d860d43362ea4609c
If you edit an entry with existing values, and during the edit, an existing value's field is hidden via conditional logic, one would expect that this value would be deleted, but it is not.
This PR resolves that issue by using
GFAPI::update_entry()
with the entry that has been generated based on the current submission. The current submission entry may differ from the entry stored in the database as GF's default form submission process does not delete values for conditionally hidden fields, only saves/updates new field values.Note: We'll probably want to implement this for Entry Blocks at some point.