Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpcld-enable-utc-timezone.js: Removed due to deprecated filter. #726

Merged
merged 4 commits into from
Nov 2, 2023
Merged

gpcld-enable-utc-timezone.js: Removed due to deprecated filter. #726

merged 4 commits into from
Nov 2, 2023

Conversation

scyt
Copy link
Contributor

@scyt scyt commented Nov 1, 2023

Context

📓 Notion: https://www.notion.so/gravitywiz/Remove-snippet-from-library-fc80503b69e9448caa0511ee00ccc673?pvs=4

Summary

Removing this snippet due to the filter being deprecated. It has been replaced with gpcld_use_visitor_timezone.

@scyt scyt marked this pull request as ready for review November 1, 2023 16:58
@scyt scyt requested a review from spivurno November 1, 2023 16:58
spivurno
spivurno requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deprecate this instead of removing it.

https://www.notion.so/gravitywiz/Snippet-Library-Code-Organization-Formatting-and-Naming-d5bee101d9674dfc98d7ec007867de2b?pvs=4#1aed582f70e640e384a3a55562939926

@scyt scyt requested a review from spivurno November 1, 2023 20:39
spivurno
spivurno approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@spivurno spivurno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one tweak – can you add a link to the docs for that filter?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against b679061

@scyt scyt merged commit 6302c5d into master Nov 2, 2023
2 checks passed
@claygriffiths claygriffiths deleted the scott/remove/gpcld-enable-utc-timezone branch December 5, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spivurno spivurno spivurno approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scyt @spivurno