gppa-ignore-current-user-filter-for-admins.php: Fixed a potential PHP error.
#728
Conversation
| @@ -25,7 +25,7 @@ | |||
| return $query_builder_args; | |||
| } | |||
|
|
|||
| array_pop( $query_builder_args['where'][ $filter_group_index ] ); | |||
There was a problem hiding this comment.
Based on this usage, this is wiping out the entire where and effectively removing all filters from what I can see.
My guess is that the issue has to do with the filter using special_value:current_user:ID not being the last filter in the group.
You'll need to loop through $query_builder_args['where'][ $filter_group_index ] and find the filter that has $filter['value'] === 'special_value:current_user:ID' and remove it from the $query_builder_args['where'][ $filter_group_index ] array.
There was a problem hiding this comment.
Okay. Actually $filter_group_index does that job fine. What is happening specifically in this test scenario is that there is only 1 filter and that is using special_value:current_user:ID. So unsetting messes up the overall structure of the $query_builder_args which is what I've fixed in the next test and pushed it. @claygriffiths
| if ( count( $query_builder_args['where'][ $filter_group_index ] ) == 0 ) { | ||
| $query_builder_args['where'] = array(); | ||
| } |
There was a problem hiding this comment.
What if there are multiple groups?
For example, if $filter_group_index is 1 here, and we have another on 2, this would clear that out as well.
claygriffiths
force-pushed
the
saif/fix/56932-fix-filter-warning
branch
from
1606381 to
2d269e2
Compare
claygriffiths
changed the title
gppa-ignore-current-user-filter-for-admins.php: Fixed an issue with snippet causing a fatal error.gppa-ignore-current-user-filter-for-admins.php: Fixed a potential PHP error.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2412200474/56932?folderId=3808239
Summary
The snippet causes a fatal error when used on-site to remove the current user ID filter for admins.