Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gw-conditional-logic-enable-current-field.php: Fixed an issue with conditional logic on current field snippet running on pages other than Form Editor. #729

Merged

Conversation

saifsultanc
Copy link
Contributor

@saifsultanc saifsultanc commented Nov 9, 2023

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2415455946/57066/

Summary

Snippet breaking Conditional Logic on Notifications. The snippet taps the JavaScript hook gform_is_conditional_logic_field which runs on Notification page, but since that isn't a Form Editor page we need to add a logic to prevent it from firing on non form editor pages.

BEFORE:
Screenshot 2023-11-09 at 9 45 01 PM

AFTER:
Screenshot 2023-11-09 at 9 44 05 PM

…conditional logic on current field snippet running on pages other than Form Editor.
@saifsultanc saifsultanc added the bug Something isn't working label Nov 9, 2023
@saifsultanc saifsultanc marked this pull request as ready for review November 9, 2023 16:15
Copy link

github-actions bot commented Nov 9, 2023

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 610663a

@claygriffiths claygriffiths changed the title gw-conditional-logic-enable-current-field.php: Fixed an issue with … gw-conditional-logic-enable-current-field.php: Fixed an issue with conditional logic on current field snippet running on pages other than Form Editor. Nov 9, 2023
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saifsultanc saifsultanc merged commit 1a82b41 into master Nov 10, 2023
5 checks passed
@saifsultanc saifsultanc deleted the saif/fix/57066-fix-conditional-logic-current-field branch November 10, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants