Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated versions for all snippets that had listed versions and were updated for GF 2.8 compatibility. #739

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

spivurno
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2447901846/58752?folderId=14960

Summary

Some of our snippets include version numbers. I neglected to update these as part of my bulk update for GF 2.8 compat here: #737

Copy link

github-actions bot commented Dec 11, 2023

Fails
🚫

Pull request title does match the correct format. The Pull Request title should match our Snippet Library Pull Request Title Guidelines in Notion.

🚫

Commit message 'Updated versions for all snippets that had listed versions and were updated for GF 2.8 compatibility.' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

🚫

Commit message '~ Oops. 😆' does match the correct format. See our Snippet Library Commit Messages Guidelines in Notion.

🚫

Commit message '~ Oops. 😆' needs to end in a period or exclamation.

Generated by 🚫 dangerJS against 15ba848

@spivurno spivurno merged commit c9dd269 into master Dec 11, 2023
3 checks passed
@spivurno spivurno deleted the dave/update/bump-versions-for-gf-2.8 branch December 11, 2023 18:17
@spivurno spivurno restored the dave/update/bump-versions-for-gf-2.8 branch December 11, 2023 18:17
@spivurno spivurno deleted the dave/update/bump-versions-for-gf-2.8 branch December 11, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants