Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gppa-acf-repeater-mapper.php: Added support for custom values with ACF field property template. #821

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

saifsultanc
Copy link
Contributor

Context

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2576524151/65219/

Summary

When using the GPPA ACF Repeater Mapper snippet, static values set in the Choice Template are ignored.

@saifsultanc saifsultanc requested a review from claygriffiths May 1, 2024 05:33
Copy link

github-actions bot commented May 1, 2024

Warnings
⚠️ When ready, don't forget to request reviews on this pull request from your fellow wizards.

Generated by 🚫 dangerJS against 4529159

Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending fixing up PHPCS issues

S&M using your existing PR title.

@saifsultanc saifsultanc changed the title gppa-acf-repeater-mapper.php: Add support for custom values with ACF field property template. gppa-acf-repeater-mapper.php: Added support for custom values with ACF field property template. May 1, 2024
@saifsultanc saifsultanc force-pushed the saif/fix/65219-support-custom-values branch from cb51522 to fe43878 Compare January 10, 2025 11:41
@saifsultanc saifsultanc force-pushed the saif/fix/65219-support-custom-values branch from fe43878 to 4529159 Compare January 10, 2025 11:45
@saifsultanc saifsultanc merged commit c75d9c4 into master Jan 10, 2025
3 checks passed
@saifsultanc saifsultanc deleted the saif/fix/65219-support-custom-values branch January 10, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants