Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpnf-delay-child-notifications-for-parent-payment.php: Added send notification if no payment status for parent entry. #976

Conversation

malayladu
Copy link
Contributor

Context

This PR allows to send notification instantly even if parent entry doesn't have payment status.

⛑️ Ticket(s): https://secure.helpscout.net/conversation/2794049850/75576

Summary

Delay notification only checks for the payment status of parent entry Paid & Active. But, it doesn't send notification if there is no payment status for the parent entry.

So, this fix checks whether the payment status is available or not. If not, it allows to send notification.

@malayladu malayladu self-assigned this Dec 30, 2024
@malayladu malayladu force-pushed the malay/add/75576-send-notification-if-no-payment-for-parent-entry branch from 780eec8 to 024fdc5 Compare December 30, 2024 13:17
@malayladu malayladu changed the title gpnf-delay-child-notifications-for-parent-payment.php: Send notification if no payment status for parent entry. gpnf-delay-child-notifications-for-parent-payment.php: Added Send notification if no payment status for parent entry. Dec 30, 2024
@malayladu malayladu changed the title gpnf-delay-child-notifications-for-parent-payment.php: Added Send notification if no payment status for parent entry. gpnf-delay-child-notifications-for-parent-payment.php: Added send notification if no payment status for parent entry. Dec 30, 2024
…otification if no payment status for parent entry.
@malayladu malayladu force-pushed the malay/add/75576-send-notification-if-no-payment-for-parent-entry branch from 024fdc5 to 75972de Compare December 31, 2024 11:36
@malayladu malayladu marked this pull request as ready for review January 7, 2025 08:46
Copy link
Contributor

@claygriffiths claygriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if everything is working as expected.

S&M with:

`gpnf-delay-child-notifications-for-parent-payment.php`: Updated behavior to send notifications if the parent entry does not have a payment status. This provides more flexibility with conditional logic.

@saifsultanc saifsultanc merged commit 353aeb7 into master Jan 8, 2025
5 checks passed
@saifsultanc saifsultanc deleted the malay/add/75576-send-notification-if-no-payment-for-parent-entry branch January 8, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants